[PATCH] D154101: [MC] Add three-state parseDirective as a replacement for ParseDirective

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 29 16:05:59 PDT 2023


MaskRay added inline comments.


================
Comment at: llvm/test/MC/MSP430/directive-byte-word-long-invalid.s:3
+
+# CHECK: [[@LINE+3]]:6: error: unknown token in expression
+# CHECK: [[@LINE+3]]:6: error: unknown token in expression
----------------
`:[[#@LINE+3]]`

`[[@LINE]]` is deprecated FileCheck syntax. I add a `:` before the line number just in case `3` matches `13`, but I don't feel useful including the filename, so... Feel free to not adopt my leading `:` suggestion.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154101/new/

https://reviews.llvm.org/D154101



More information about the llvm-commits mailing list