[PATCH] D153566: [InstSimplify] Fix a scalable-vector crash

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 28 04:55:21 PDT 2023


arsenm added inline comments.


================
Comment at: llvm/lib/Analysis/InstructionSimplify.cpp:5472
+  // on our hands. Grab that before splatting a QNaN constant.
+  if (isa<ScalableVectorType>(Ty)) {
+    auto *Splat = In->getSplatValue();
----------------
Why is this down here and not another dyn_cast<ScalableVector> after the FixedVectorType case?


================
Comment at: llvm/test/Transforms/InstSimplify/fp-nan.ll:59
+}
+
 ; Signaling and signed - make quiet and preserve the payload and signbit
----------------
Add some scalable vector tests with other FP classes?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153566/new/

https://reviews.llvm.org/D153566



More information about the llvm-commits mailing list