[PATCH] D150803: Add a new `wasm_custom` clang attribute for marking functions.

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 27 15:14:20 PDT 2023


sbc100 added a comment.

In D150803#4454164 <https://reviews.llvm.org/D150803#4454164>, @brendandahl wrote:

> In D150803#4440802 <https://reviews.llvm.org/D150803#4440802>, @aaron.ballman wrote:
>
>> Marking as requested changes so it's clear there's more worth discussing, so we don't accidentally land this.
>
> I've switched to using `annotate` now. Let me know if there's anything else.

I guess the CL title and description now need updating?   Nice to see we no longer need any clang changes here!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150803/new/

https://reviews.llvm.org/D150803



More information about the llvm-commits mailing list