[PATCH] D152276: [DAGCombine] Fold (store (insert_elt (load p)) x p) -> (store x)

Luke Lau via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 27 09:16:23 PDT 2023


luke marked an inline comment as done.
luke added inline comments.


================
Comment at: llvm/test/CodeGen/X86/fold-load-vec.ll:17
+; CHECK-NEXT:    unpcklps {{.*#+}} xmm0 = xmm0[0],xmm1[0],xmm0[1],xmm1[1]
+; CHECK-NEXT:    movss %xmm1, {{[0-9]+}}(%rsp)
 ; CHECK-NEXT:    movlps %xmm0, (%rsi)
----------------
RKSimon wrote:
> Limit to cases where the insertion is the only user of the load?
Sorry for the delay, rebased and updated now. Limiting to loads with a single use didn't fix this case, but limiting to inserts with a single use worked instead


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152276/new/

https://reviews.llvm.org/D152276



More information about the llvm-commits mailing list