[PATCH] D153660: [ConstraintElim] Track and simplify conditions at use.

Tue Jun 27 08:27:48 PDT 2023

fhahn marked 3 inline comments as done.
fhahn added a comment.

In D153660#4452713 <https://reviews.llvm.org/D153660#4452713>, @nikic wrote:

> In D153660#4452408 <https://reviews.llvm.org/D153660#4452408>, @fhahn wrote:
>
>> Yep, if the fact is only known on the edge then we don't simplify it at the moment. This could probably be handled by making the fact handling more fine-grained.
>>
>> I *think* this should already be covered by the following test. It's a 3 entry phi, not sure if it is worth adding a dedicated simpler case? https://github.com/llvm/llvm-project/blob/main/llvm/test/Transforms/ConstraintElimination/cond-used-in-phi.ll#L221
>
> Ah yes, that does cover the case. Nevermind then.
>
> LGTM with the nits addressed.

Thanks! Just to double check, the previous nits should already be addressed, where there any additional nits that may not got submitted?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153660/new/

https://reviews.llvm.org/D153660