[PATCH] D152758: [NFC] Refactor MBB hotness/coldness into templated PSI functions

Wenlei He via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jun 25 16:27:11 PDT 2023


wenlei accepted this revision.
wenlei added a comment.
This revision is now accepted and ready to land.

Thanks for the refactoring and cleanup. LGTM.



================
Comment at: llvm/include/llvm/Analysis/ProfileSummaryInfo.h:127
   /// Returns true if \p F contains hot code.
-  bool isFunctionHotInCallGraph(const Function *F,
-                                BlockFrequencyInfo &BFI) const;
+  template <typename FunctionType, typename BFIT>
+  bool isFunctionHotInCallGraph(const FunctionType *F, BFIT &BFI) const {
----------------
nit: FunctionType->FuncT to be consistent with BFIT and other template definitions. 




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152758/new/

https://reviews.llvm.org/D152758



More information about the llvm-commits mailing list