[PATCH] D153660: [ConstraintElim] Track and simplify conditions at use.

Sun Jun 25 09:10:42 PDT 2023

fhahn marked an inline comment as done.
fhahn added a comment.

In D153660#4446248 <https://reviews.llvm.org/D153660#4446248>, @nikic wrote:

> Can you please add some tests with uses in phi nodes? I don't think the handling for those is correct. (Though more in the direction of missing some replacements that were previously done rather than doing invalid replacements.)

I added some tests in 0ddfb802e4ca <https://reviews.llvm.org/rG0ddfb802e4cab9782d0b6dda6916e0062493f0cf>. Is that what you had in mind? I think we shouldn't miss any of those, because the code should ensure that the uses in the context instruction (the user of the use we queued) is always replaced.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153660/new/

https://reviews.llvm.org/D153660