[PATCH] D153207: [AArch64] Add patterns for scalar FMUL, FMULX

OverMighty via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jun 25 08:26:36 PDT 2023


overmighty added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.td:4432
 
+multiclass FPScalarFromIndexedLane0Patterns<string inst, string inst_f16_suffix,
+                                            string inst_f32_suffix,
----------------
overmighty wrote:
> I wasn't sure where to put this.
Also, I assume this multiclass needs a better name that mentions the number of operands for the instructions. Scalar FMUL invokes `TwoOperandFPData` but scalar FMULX invokes `SIMDFPThreeScalar`, I'm not sure if something like `TwoOperandFPDataFromLane0Patterns` would be a better name.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153207/new/

https://reviews.llvm.org/D153207



More information about the llvm-commits mailing list