[PATCH] D117929: [XRay] Add support for RISCV

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.
Herald added subscribers: wangpc, luke, Enna1, shiva0217, arichardson.
Herald added a project: All.

I am still interested in a RISC-V XRay port :)



================
Comment at: llvm/lib/Target/RISCV/RISCVAsmPrinter.cpp:280
+  // Emit NOP instructions
+  for (int8_t I = 0; I < NoopsInSledCount; I++)
+    EmitToStreamer(*OutStreamer, MCInstBuilder(RISCV::ADDI)
----------------
`int`

https://llvm.org/docs/CodingStandards.html#prefer-preincrement


================
Comment at: llvm/test/CodeGen/RISCV/xray-attribute-instrumentation.ll:8
+; CHECK-NEXT:           j .Ltmp0
+; CHECK-NEXT:           nop
+; CHECK-NEXT:           nop
----------------
Use COUNT https://llvm.org/docs/CommandGuide/FileCheck.html#the-check-count-directive

See llvm/test/CodeGen/AArch64/xray-attribute-instrumentation.ll


================
Comment at: llvm/test/CodeGen/RISCV/xray-attribute-instrumentation.ll:54
+; CHECK-LABEL:          .Lxray_sleds_start0:
+; CHECK:                .Lxray_sled_0-.Ltmp2
+; CHECK:                .Lxray_sled_1-.Ltmp3
----------------
See llvm/test/CodeGen/X86/xray-attribute-instrumentation.ll 

use `[[TMP:.Ltmp[0-9]+]]` to avoid updating `.LtmpN` when there are somehow other temporary labels.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117929/new/

https://reviews.llvm.org/D117929