[PATCH] D153588: [Pseudo Probe] Remove the assert of allowing only one call probe for a callsite.

Wenlei He via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 23 14:54:55 PDT 2023


wenlei added a comment.

> Due to the the way .pseudo_probe section is decoded, probes of the same-named independent static functions are merged

Is this because dwarf based name (the container for probes) doesn't have the concept of static function and all functions are keyed on names (TopLevelProbeFrameMap), so we can't differentiate static functions of the same name?

I might misunderstand it initially, but this seems like a flaw we should try to fix? Two static functions can be completely different, and we need to have the capability to differentiate them..


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153588/new/

https://reviews.llvm.org/D153588



More information about the llvm-commits mailing list