[PATCH] D153665: [llvm-libtool-darwin] Switch to OptTableSummary

Shoaib Meenai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 23 14:38:47 PDT 2023


smeenai added a comment.

This looks good, but could you add the motivation for the change to the commit description as well?



================
Comment at: llvm/tools/llvm-libtool-darwin/Opts.td:23
+                       " ends with '.o', then the library 'x' is searched for without prepending 'lib' or appending '.a'">, MetaVarName<"x">;
+def librarySearchDirs : J<"L", "L<dir> adds <dir> to the list of directories in which to search for libraries">, MetaVarName<"dir">;
+def ignoredSyslibRoot : SS<"syslibroot", "">, Flags<[HelpHidden]>;
----------------
Apple's libtool accepts this option with or without a space, so this should be SeparateOrJoined (and the help should be updated accordingly).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153665/new/

https://reviews.llvm.org/D153665



More information about the llvm-commits mailing list