[PATCH] D153643: [GlobalIsel][X86] G_STORE extension

[Matt Arsenault via Phabricator via llvm-commits]

arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.

LGTM but drop the filler undef value references



================
Comment at: llvm/test/CodeGen/X86/GlobalISel/legalize-store-avx.mir:18
+    %1:_(p0) = IMPLICIT_DEF
+    G_STORE %0:_(<2 x s32>), %1:_(p0) :: (store (<2 x s32>) into `ptr undef`)
+    %2:_(p0) = COPY %1:_(p0)
----------------
don't need into `ptr undef`, can just not have a value reference


================
Comment at: llvm/test/CodeGen/X86/GlobalISel/legalize-store-sse.mir:43
+body:             |
+  bb.1:
+    ; X86-64-SEE-LABEL: name: test_gstore_v2p0
----------------
bb.0


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153643/new/

https://reviews.llvm.org/D153643