[PATCH] D152905: [AMDGPU][GFX11] Add test coverage for 16-bit conversions, part 12.

[Ivan Kosarev via Phabricator via llvm-commits]

kosarev added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/function-args.ll:89
-; GCN-LABEL: {{^}}void_func_i16_zeroext:
-; GCN-NOT: v0
-; GCN: v_add_{{i|u}}32_e32 v0, {{(vcc, )?}}12, v0
----------------
Joe_Nash wrote:
> The changes to llvm.amdgcn.raw.buffer.store.ll and llvm.amdgcn.struct.buffer.store.ll LGTM.
> 
> The changes to function-args.ll, I'm not so sure about. There are a lot of not lines. I don't know what properties these are ensuring, but I know something was being checked. When we remove those and go to auto-generated, there is no evidence some property was being checked. A use of v0 in this case.
>From what I see the -NOT lines just make sure there are no redefinitions or extra uses of the registers of interest and no extra `s_waitcnt` instructions, deviations from which in all cases should be easy to catch by the usual examination of changes in the autogenerated checks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152905/new/

https://reviews.llvm.org/D152905