[PATCH] D153503: [AMDGPU] Add opt-pipeline test for NewPM.

[Nikita Popov via Phabricator via llvm-commits]

nikic added a comment.

In D153503#4443308 <https://reviews.llvm.org/D153503#4443308>, @pravinjagtap wrote:

> In D153503#4441472 <https://reviews.llvm.org/D153503#4441472>, @aeubanks wrote:
>
>> do we really need to test every pass when it's almost identical to the existing tests? can we just test that the specific passes that AMDGPU adds are in the pipeline?
>
> I think, then, we will not be able to capture changes required in pipeline when someone updates AMDGPU Pass which depends on non-target specific pass. For example, in D153349 <https://reviews.llvm.org/D153349>, the AMDGPUAtomicOptimizer uses dom-tree but updating the dom-tree in the pass and preserving the analysis did not ask for updating the any of the pipeline tests.

Unfortunately, NewPM pipeline tests will not help you find missing pass invalidations, because it depends on on the specific IR and whether the pass ended up changing something or not. The pipeline tests are generally designed to avoid any invalidations (that are not part of the pass pipeline itself).

I don't think there is any good way to find NewPM invalidation issues right now, apart from directly tracking compile-time.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153503/new/

https://reviews.llvm.org/D153503