[PATCH] D151906: [BOLT][DWARF] Fix new debug re-writer

[Maksim Panchenko via Phabricator via llvm-commits]

maksfb added inline comments.


================
Comment at: bolt/lib/Core/DIEBuilder.cpp:81-88
+    if (LocExpr.Form == dwarf::DW_FORM_exprloc)
+      Value =
+          DIEValue(dwarf::Attribute(LocExpr.Attr), dwarf::Form(LocExpr.Form),
+                   static_cast<DIELoc *>(AttrVal));
+    else
+      Value =
+          DIEValue(dwarf::Attribute(LocExpr.Attr), dwarf::Form(LocExpr.Form),
----------------
Use braces.


================
Comment at: bolt/lib/Core/DIEBuilder.cpp:443
          Description.Op[0] != Encoding::Size1))
-      outs() << "BOLT-INFO: Unsupported DW_OP encoding.\n";
+      outs() << "BOLT-WARNING: [internal-dwarf-error]: unsupported DW_OP "
+                "encoding.\n";
----------------



================
Comment at: bolt/lib/Core/DIEBuilder.cpp:444
+      outs() << "BOLT-WARNING: [internal-dwarf-error]: unsupported DW_OP "
+                "encoding.\n";
 
----------------



================
Comment at: bolt/lib/Core/DIEBuilder.cpp:545-550
+  if (Loc)
+    Value = DIEValue(dwarf::Attribute(AttrSpec.Attr),
+                     dwarf::Form(AttrSpec.Form), Loc);
+  else
+    Value = DIEValue(dwarf::Attribute(AttrSpec.Attr),
+                     dwarf::Form(AttrSpec.Form), Block);
----------------
Braces.


================
Comment at: bolt/lib/Core/DIEBuilder.cpp:607
+              "attribute form. Dropping "
               "attribute.\n";
 
----------------



================
Comment at: bolt/lib/Rewrite/DWARFRewriter.cpp:1849
+  const unsigned NUmCUsEncoded = CUListSize / 16;
+  unsigned MaxDWARFVersion = BC.DwCtx->getMaxVersion();
+  unsigned NumDWARF5TUs =
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151906/new/

https://reviews.llvm.org/D151906