[PATCH] D153559: [libLTO] Add support for -save-temps

Qiongsi Wu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 22 10:47:33 PDT 2023


qiongsiwu1 added a comment.

In D153559#4441538 <https://reviews.llvm.org/D153559#4441538>, @tejohnson wrote:

> It would be better to work with @fhahn on the old patch (you can commandeer it if he is ok with that), so that comment history is preserved. But I have some comments on this version that I will add here.  Looks like a test is still needed (this patch affects legacy regular LTO, the prior llvm-lto tests would have only used the existing option for ThinLTO - see thinlto-save-temps flag in llvm-lto.cpp). I'll leave a comment on the original version, I think it makes sense to common up the options used for this between thin and regular LTO in the legacy LTO API and its tool, llvm-lto.

Thanks so much for the comment @tejohnson !! @fhahn Let me know if you are ok with me taking over the original patch https://reviews.llvm.org/D98183. I will close this patch and continue the work there (consolidating options between LTO/thinLTO and adding tests). Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153559/new/

https://reviews.llvm.org/D153559



More information about the llvm-commits mailing list