[PATCH] D153316: [AArch64][SelectionDAG] fix infinite loop caused by legalizing & combining CONCAT_VECTORS

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 22 07:19:58 PDT 2023


RKSimon added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/dag-combine-concat-vectors.ll:1
+; RUN: llc -mtriple=aarch64-none-eabi -mattr=+sve < %s
+; check whether commands above could exit normally rather than get stuck in the infinite loop
----------------
FLZ101 wrote:
> RKSimon wrote:
> > Add a FileCheck and run update_llc_test_checks to generate codegen to test
> Is there a way to check whether the case could be finished in for example 10s ? I think that would be more appropriate
We don't tend to bother with timelimit tests as (IIRC) some buildbots struggle to handle them correctly.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153316/new/

https://reviews.llvm.org/D153316



More information about the llvm-commits mailing list