[PATCH] D153502: [DAGCombiner] Change foldAndOrOfSETCC() to optimize and/or patterns

[Jay Foad via Phabricator via llvm-commits]

foad added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:6064
+    SDValue Operand2;
+    if (LHS1C && RHS1C) {
+      CommonValue = LHS1;
----------------
I don't understand why you handle constants differently from non-constants. Are you worried about two different constant nodes having the same constant value?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153502/new/

https://reviews.llvm.org/D153502