[PATCH] D148710: [DAGCombiner] Hoist add/sub binop w/ constant op only if it won't increase divergency node

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 22 06:56:26 PDT 2023


arsenm added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/llvm.amdgcn.s.barrier.ll:77
 ; VARIANT3-NEXT:    global_store_dword v2, v0, s[2:3]
-; VARIANT3-NEXT:    v_xad_u32 v0, v0, -1, s4
 ; VARIANT3-NEXT:    v_ashrrev_i32_e32 v1, 31, v0
----------------
This is the kind of regression I expect out of globalisel, I'm surprised the DAG regressed here


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148710/new/

https://reviews.llvm.org/D148710



More information about the llvm-commits mailing list