[PATCH] D143180: DAG: Expand legalization of is.fpclass to fcmp for DAZ

Thu Jun 22 03:18:19 PDT 2023

arsenm closed this revision.
arsenm marked an inline comment as done.
arsenm added a comment.

18b93562cfcf0fb728e6fc985855f3e74aac438d <https://reviews.llvm.org/rG18b93562cfcf0fb728e6fc985855f3e74aac438d>

================
Comment at: llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp:8107-8108
+    if (isFCmpEqualZero(Test, Semantics, DAG.getMachineFunction())) {
+      // If denormals could be implicitly treated as 0, this is not equivalent
+      // to a compare with 0 since it will also be true for denormals.
+      return DAG.getSetCC(DL, ResultVT, Op,
----------------
sepavloff wrote:
> It looks like this comment is misplaced.
Don't really see what you mean by this

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143180/new/

https://reviews.llvm.org/D143180