[PATCH] D153464: Revert "[CaptureTracking] Ignore ephemeral values when determining pointer escapeness"

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 21 14:55:14 PDT 2023


fhahn updated this revision to Diff 533412.
fhahn added a comment.

Remove FIXME, update assmue.ll checks.

In D153464#4439187 <https://reviews.llvm.org/D153464#4439187>, @aeubanks wrote:

>> Because the call doesn't capture the pointer, it's considered to not read the pointer
>
> this part doesn't make sense, DSE must be conflating the two somehow (but only for ephemeral values?)

I think AA uses capture tracking to rule out aliasing for function calls if a local object hasn't been captured.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153464/new/

https://reviews.llvm.org/D153464

Files:
  llvm/include/llvm/Analysis/AliasAnalysis.h
  llvm/include/llvm/Analysis/CaptureTracking.h
  llvm/lib/Analysis/BasicAliasAnalysis.cpp
  llvm/lib/Analysis/CaptureTracking.cpp
  llvm/lib/Transforms/Scalar/DeadStoreElimination.cpp
  llvm/test/Transforms/DeadStoreElimination/assume.ll
  llvm/test/Transforms/PhaseOrdering/dse-ephemeral-value-captures.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D153464.533412.patch
Type: text/x-patch
Size: 13025 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230621/0e54c464/attachment.bin>


More information about the llvm-commits mailing list