[PATCH] D153373: Define/guard MLIR_STANDALONE_BUILD LLVM_LIBRARY_OUTPUT_INTDIR var.

Wed Jun 21 08:18:34 PDT 2023

stellaraccident added a comment.

In D153373#4437945 <https://reviews.llvm.org/D153373#4437945>, @tmatheson wrote:

> I don't think this is the right fix, as all the other uses of `LLVM_LIBRARY_OUTPUT_INTDIR` in `AddLLVM` are optional. See for example D13215 <https://reviews.llvm.org/D13215>.
>
> Anyone building against an installed LLVM now has to define `LLVM_LIBRARY_OUTPUT_INTDIR` or their build will fail.

Good point. Shall I patch this to only add the rpath-link flag if that is set.

TBH - I was looking at this locally and just saw that it was non optional in fact (it. It corrupts the liner command line) and didn't ask the question as to whether the entire check should be conditioned.

Let me do a revert because it sounds like it will break people. Then can roll forward a proper fix.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153373/new/

https://reviews.llvm.org/D153373