[PATCH] D152437: PowerPC/SPE: Add phony registers for high halves of SPE SuperRegs

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 21 03:52:20 PDT 2023


arsenm added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCFrameLowering.cpp:2333
+    // In case of SPE we only have SuperRegs and CRs
+    // in our CalleSaveInfo vector.
+
----------------
This looks like you're working around inaccurate CSR regmasks. You should try adjusting those instead 


================
Comment at: llvm/lib/Target/PowerPC/PPCFrameLowering.cpp:2338
+      const MCPhysReg &Reg = CalleeSaveReg.getReg();
+      const MCPhysReg &Lower = RegInfo->getSubReg(Reg, 1);
+      const MCPhysReg &Higher = RegInfo->getSubReg(Reg, 2);
----------------
Don't use reference to MCPhysReg


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152437/new/

https://reviews.llvm.org/D152437



More information about the llvm-commits mailing list