[PATCH] D153318: [llvm] Refactor BalancedPartitioning for fixing build failure with MSVC

kamlesh kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 20 18:32:57 PDT 2023


kamleshbhalui added inline comments.


================
Comment at: llvm/include/llvm/Support/BalancedPartitioning.h:118
   struct BPThreadPool {
-    ThreadPool TheThreadPool;
+    ThreadPool &TheThreadPool;
     std::mutex mtx;
----------------
ellis wrote:
> Why not keep `ThreadPool` owned by `BPThreadPool`? Why make this an alias?
We do not know complete type of  ThreadPool here so we can not do that. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153318/new/

https://reviews.llvm.org/D153318



More information about the llvm-commits mailing list