[PATCH] D153364: [llvm][DebugInfo] Emit DW_AT_defaulted for defaulted C++ member functions

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 20 13:29:36 PDT 2023


dblaikie added inline comments.


================
Comment at: llvm/include/llvm/IR/DebugInfoFlags.def:94-95
 HANDLE_DISP_FLAG((1u << 11), ObjCDirect)
+HANDLE_DISP_FLAG((1u << 12), DefaultedInClass)
+HANDLE_DISP_FLAG((1u << 13), DefaultedOutOfClass)
 
----------------
Is there any particular benefit to providing this fidelity (the difference between defaulted in class and defaulted out of class)? (sorry, this might split the "motivation" design discussion between this patch and the clang frontend patch) and/or should we use an enum here (it wouldn't save us a bit, but would avoid create a representation that could have both `DefaultedInClass` and `DefaultedOutOfClass` true at the same time, which isn't necessary/useful)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153364/new/

https://reviews.llvm.org/D153364



More information about the llvm-commits mailing list