[PATCH] D153106: [CSKY] Optimize multiplication with immediates

[Zixuan Wu via Phabricator via llvm-commits]

zixuan-wu added inline comments.


================
Comment at: llvm/lib/Target/CSKY/CSKYSubtarget.h:210
+
+  unsigned getDataSizeInBits() const { return 32; }
 };
----------------
benshi001 wrote:
> zixuan-wu wrote:
> > I think the name getDataSizeInBits is not precise about target machine. 
> > 
> > ```
> > static const unsigned XLEN = 32;
> > ```
> > 
> > may be better?
> I prefer `const unsigned XLen = 32;`. 
LGTM


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153106/new/

https://reviews.llvm.org/D153106