[PATCH] D153106: [CSKY] Optimize multiplication with immediates

Ben Shi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 19 19:50:08 PDT 2023


benshi001 marked an inline comment as done.
benshi001 added inline comments.


================
Comment at: llvm/lib/Target/CSKY/CSKYISelLowering.cpp:1386
+  // Omit if data size exceeds 32-bit.
+  if (VT.getSizeInBits() > 32)
+    return false;
----------------
zixuan-wu wrote:
> Can the 32 hard code be const variable which can be defined in Subtarget consistently?
Done. I have created a `CSKYSubtarget::getDataSizeInBits()` for that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153106/new/

https://reviews.llvm.org/D153106



More information about the llvm-commits mailing list