[PATCH] D153106: [CSKY] Optimize multiplication with immediates

[Zixuan Wu via Phabricator via llvm-commits]

zixuan-wu accepted this revision.
zixuan-wu added a comment.
This revision is now accepted and ready to land.

LGTM. With minor change that the title of this revision can be more concrete.



================
Comment at: llvm/lib/Target/CSKY/CSKYISelLowering.cpp:1386
+  // Omit if data size exceeds 32-bit.
+  if (VT.getSizeInBits() > 32)
+    return false;
----------------
Can the 32 hard code be const variable which can be defined in Subtarget consistently?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153106/new/

https://reviews.llvm.org/D153106