[PATCH] D153280: [AMDGPU] Forbid dynamic alloca on PAL ABI

Mon Jun 19 08:04:46 PDT 2023

sebastian-ne added a comment.

In D153280#4432808 <https://reviews.llvm.org/D153280#4432808>, @arsenm wrote:

> This doesn't make sense. If you can externally set the stack size as was claimed in a previous patch, you support dynamic allocas

If you are referring to D150609 <https://reviews.llvm.org/D150609>, graphics uses indirect calls (under some known circumstances). It doesn’t use or support dynamic allocas.

Due to a bug in the compiler frontend, allocas got shifted into a non-entry block, which segfaulted in combination with D150609 <https://reviews.llvm.org/D150609>, therefore this patch to make sure nobody tries to use them.
The patch to fix the frontend is in https://github.com/GPUOpen-Drivers/llpc/pull/2542 for reference.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153280/new/

https://reviews.llvm.org/D153280