[PATCH] D152993: [VP][RISCV] Add vp.is.fpclass and RISC-V support

Liao Chunyu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 19 07:35:42 PDT 2023


liaolucy added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:7929
+    SDNodeFlags SDFlags;
+    if (auto *FPMO = dyn_cast<FPMathOperator>(&VPIntrin))
+      SDFlags.copyFMF(*FPMO);
----------------
craig.topper wrote:
> We don't copy fast math flags for llvm.is.fpclass. Why do we copy them here?
I tried to refer to the is_fpclass reserved flag before, but got it wrong. It looks normal now.
https://github.com/llvm/llvm-project/blob/main/llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp#L6579 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152993/new/

https://reviews.llvm.org/D152993



More information about the llvm-commits mailing list