[PATCH] D151369: ValueTracking: Handle compare to nan and -inf constants in fcmpToClassTest

[Jay Foad via Phabricator via llvm-commits]

foad added inline comments.


================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:4267
     }
+    case FCmpInst::FCMP_OGT: {
+      if (ConstRHS->isNegative())
----------------
Should handle OGT and ULE as a pair, like you do for all the other inverse pairs.


================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:4278
+
+      // All values are unordered with and at most infinity.
+      return {Src, fcAllFlags};
----------------
"or"


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151369/new/

https://reviews.llvm.org/D151369