[PATCH] D152944: [BOLT] Mark sections read-only based on PT_GNU_RELRO segment

[Maksim Panchenko via Phabricator via llvm-commits]

maksfb requested changes to this revision.
maksfb added a comment.
This revision now requires changes to proceed.

I think we need a new type for RELRO sections. We rely on the contents of regular read-only sections to match that in the file. While for RELRO, the contents will depend on the presence of runtime relocations against any region and the type of relocations.

> Update gotpcrelx.s test as we start recognizing jmp *foo at GOTPCREL(%rip) as fixed indirect jump and convert it to a tail call with X86::JMP32m opcode.

If we recognize it as a fixed jump, why does the test case still have an indirect jump?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152944/new/

https://reviews.llvm.org/D152944