[PATCH] D153086: [llvm-gsymutil] Fix command descriptions introduced in upstream D148775 when switching to OptTable

Wanyi Ye via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 15 16:43:32 PDT 2023


kusmour created this revision.
kusmour added reviewers: clayborg, yinghuitan.
Herald added a project: All.
kusmour requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

D148775 <https://reviews.llvm.org/D148775> changed the help msg for `--addresses-from-stdin` option when switching to OptTable

This patch also fixed a small problem in the argument type error msg


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D153086

Files:
  llvm/tools/llvm-gsymutil/Opts.td
  llvm/tools/llvm-gsymutil/llvm-gsymutil.cpp


Index: llvm/tools/llvm-gsymutil/llvm-gsymutil.cpp
===================================================================
--- llvm/tools/llvm-gsymutil/llvm-gsymutil.cpp
+++ llvm/tools/llvm-gsymutil/llvm-gsymutil.cpp
@@ -174,7 +174,7 @@
   for (const llvm::opt::Arg *A : Args.filtered(OPT_address_EQ)) {
     StringRef S{A->getValue()};
     if (!llvm::to_integer(S, LookupAddresses.emplace_back(), 0)) {
-      llvm::errs() << ToolName << ": for the --segment-size option: '" << S
+      llvm::errs() << ToolName << ": for the --address option: '" << S
                    << "' value invalid for uint argument!\n";
       std::exit(1);
     }
Index: llvm/tools/llvm-gsymutil/Opts.td
===================================================================
--- llvm/tools/llvm-gsymutil/Opts.td
+++ llvm/tools/llvm-gsymutil/Opts.td
@@ -34,7 +34,7 @@
 defm address : Eq<"address", "Lookup an address in a GSYM file">;
 def addresses_from_stdin :
   FF<"addresses-from-stdin",
-     "Emit a section containing remark diagnostics metadata. By default, this is enabled for the following formats: yaml-strtab, bitstream">;
+     "Lookup addresses in a GSYM file that are read from stdin\nEach input line is expected to be of the following format: <addr> <gsym-path>">;
 defm symtab_file :
   Eq<"symtab-file",
      "Specify a separate file for symbol table to GSYM conversion.\nIn case the symbol table and debug info are not in the same binary. Does not support universal binary.">;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D153086.531941.patch
Type: text/x-patch
Size: 1470 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230615/c306556c/attachment.bin>


More information about the llvm-commits mailing list