[PATCH] D153004: [LSR] Consider post-inc form when creating extends/truncates.

[Florian Hahn via Phabricator via llvm-commits]

fhahn added a comment.

In D153004#4423957 <https://reviews.llvm.org/D153004#4423957>, @nikic wrote:

> Did you see D151796 <https://reviews.llvm.org/D151796>? What you're doing here presumably still relies on denormalization and normalization round-tripping, which is not actually the case.

I saw this one a while ago, but it dropped off my radar!

The patch relies on round-tripping, but addresses a different issue I think. For the 2 linked issues, the problem is that we build new expressions based on normalized expressions and that is incorrect in some cases if they are used by something that needs the post-inc. IIUC to squash all potential mis-compiles, we would need to ensure that round-tripping will always succeed ( D151796 <https://reviews.llvm.org/D151796> is a first step) & new expressions based on normalized expressions remain correct in for post-inc users (this patch is a first step).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153004/new/

https://reviews.llvm.org/D153004