[PATCH] D152937: [RISCV] Document overview of vector psuedos [nfc]

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 14 13:39:27 PDT 2023


craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfo.h:303
+  this concept does not exist in the specification, and requires source
+  knownledge to be preserved.
+
----------------
knownledge -> knowledge


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfo.h:328
+  overlap constraint mentioned above.
+ */
+struct RISCVMaskedPseudoInfo {
----------------
How do we represent "undefined" for fma, integer multiple-accumulate where the destination is also an arithmetic source. Also vslideup where the destination is used for elements below offset and for the tail, but only tail follows the tail policy.

How do we represent tail "undefined" vs tail "agnostic" for _MASK?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152937/new/

https://reviews.llvm.org/D152937



More information about the llvm-commits mailing list