[PATCH] D152838: [ValueTracking] Add range computation from dominating conditions

Noah Goldstein via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 14 11:45:33 PDT 2023


goldstein.w.n added inline comments.


================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:6053
+  if (match(Condition, m_ICmp(Pred, m_Specific(V), m_APInt(C))))
+    if (C->getBitWidth() == BitWidth)
+      return ConstantRange::makeExactICmpRegion(Pred, *C);
----------------
I don't think this check is needed. LHS/RHS will always be the same type.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152838/new/

https://reviews.llvm.org/D152838



More information about the llvm-commits mailing list