[PATCH] D152924: [libLTO][AIX] Respect `-f[no]-integrated-as` on AIX

Wed Jun 14 10:07:23 PDT 2023

qiongsiwu1 added a comment.

In D152924#4421624 <https://reviews.llvm.org/D152924#4421624>, @steven_wu wrote:

> `lld` does not use LTOCodeGenerator.
>
> I am also not sure how disable integrated assembler suppose to work? Do you have an end to end design for how to invoke assembler during linking? For current libLTO API, this is probably going to produce assembler file buffer to linker, which is not usable by linker.

Thanks for chiming in @steven_wu! This patch is enabling `-f[no-]-integrated-as` on //AIX only//. There is already code to invoke the assembler during linking https://github.com/llvm/llvm-project/blob/807adcf4b9cca5586fd1fb669811768528d9dd1d/llvm/lib/LTO/LTOCodeGenerator.cpp#L343. `clang` will emit a warning on other platforms. The patch title is revised to reflect that this feature is AIX only at the moment.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152924/new/

https://reviews.llvm.org/D152924