[PATCH] D150384: [CodeGenPrepare] Fix for using outdated/corrupt LoopInfo

Momchil Velikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 14 02:05:35 PDT 2023


chill added inline comments.


================
Comment at: llvm/lib/CodeGen/CodeGenPrepare.cpp:652
+    LI->verify(getDT(F));
+#endif
+
----------------
efriedma wrote:
> Given the way the code is structured, isn't this always running just after you've just called releaseMemory()/analyze() on LI?
D'oh, indeed, after we exit the loop because of `MadeChange` being `false` it means all the code after `LI->analyze` didn't do anything, including changing the loop structure.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150384/new/

https://reviews.llvm.org/D150384



More information about the llvm-commits mailing list