[PATCH] D152844: [RISCV][InsertVSETVLI] Rework code structure to make reasoning about undefined lanes explicit [NFC]

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 13 11:10:06 PDT 2023


reames created this revision.
reames added reviewers: craig.topper, luke, asb, frasercrmck, kito-cheng.
Herald added subscribers: jobnoorman, VincentWu, vkmr, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, niosHD, sabuasal, bollu, simoncook, johnrusso, rbar, hiraditya, arichardson, mcrosier.
Herald added a project: All.
reames requested review of this revision.
Herald added subscribers: pcwang-thead, eopXD, MaskRay.
Herald added a project: LLVM.

We already have several places in this code which reason about whether the inactive lanes are defined, and are about to add one more in D151653 <https://reviews.llvm.org/D151653>.  Let's go ahead and common the code so that we don't have the same concept repeating in multiply places.

Asking for review mostly because of the change to computeInfoForInstr.  I want a second pair of eyes confirming I'm not missing something there.  (All of the removed asserts are covered by the verifier; I checked.)


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D152844

Files:
  llvm/lib/Target/RISCV/RISCVInsertVSETVLI.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D152844.530993.patch
Type: text/x-patch
Size: 4713 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230613/c14a8681/attachment.bin>


More information about the llvm-commits mailing list