[PATCH] D150803: [WebAssembly] Add a new `wasm_async` clang attribute for marking async functions.

Aaron Ballman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 13 07:29:43 PDT 2023


aaron.ballman added a comment.

Aside from the suggested changes, the Clang bits LGTM



================
Comment at: clang/lib/Sema/SemaDeclAttr.cpp:7636-7639
+static void handleWebAssemblyAsyncAttr(Sema &S, Decl *D, const ParsedAttr &AL) {
+  D->addAttr(::new (S.Context) WebAssemblyAsyncAttr(S.Context, AL));
+}
+
----------------
This can be removed entirely (see edit below).


================
Comment at: clang/lib/Sema/SemaDeclAttr.cpp:8747
+  case ParsedAttr::AT_WebAssemblyAsync:
+    handleWebAssemblyAsyncAttr(S, D, AL);
+    break;
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150803/new/

https://reviews.llvm.org/D150803



More information about the llvm-commits mailing list