[PATCH] D143984: [DebugMetadata] Simplify handling subprogram's retainedNodes field. NFCI (1/7)

Vladislav Dzhidzhoev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 12 09:42:34 PDT 2023


dzhidzhoev added a comment.

Updated DebugInfo test of OCaml binding.

In D143984#4409015 <https://reviews.llvm.org/D143984#4409015>, @dblaikie wrote:

> When we migrated to github we gained higher fidelity for attributing authors (we can now commit on someone's behalf but have the commit author properly recorded as the real author - we couldn't do that back on Subversion) - but I think it's meant that fail-mail from bots goes to that author, and not to the committer. Ideally it'd go to both - so, as it stands now, being a commiter-but-not-author is tricky, because you don't get the feedback on the commit you made. You might watch buildbots manually, or at least bhe responsive to other people complaining on the reviews like this.

Thanks! We agreed to use Authored-by attribute.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143984/new/

https://reviews.llvm.org/D143984



More information about the llvm-commits mailing list