[PATCH] D152538: `G_ATOMICRMW_NAND` failure in legalizer

niwin anto via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jun 10 06:25:42 PDT 2023


niwinanto marked 7 inline comments as done.
niwinanto added inline comments.


================
Comment at: llvm/unittests/CodeGen/GlobalISel/LegalizerHelperTest.cpp:4198
+
+  auto MIBAtomicRMWNand = B.buildAtomicRMWNand(OldValRes, Addr, Val, *MMO);
+
----------------
arsenm wrote:
> niwinanto wrote:
> > arsenm wrote:
> > > can just specify the return type here
> > You meant `auto MIBAtomicRMWNand` to `MachineInstrBuilder MIBAtomicRMWNand`, or?
> auto Nand = B.buildAtomicRMW(LLT::scalar(32))
I don't get the issue with `buildAtomicRMWNand`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152538/new/

https://reviews.llvm.org/D152538



More information about the llvm-commits mailing list