[PATCH] D152351: [clang] Add __builtin_isfpclass

Aaron Ballman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 9 12:03:23 PDT 2023


aaron.ballman added a comment.

In D152351#4409725 <https://reviews.llvm.org/D152351#4409725>, @sepavloff wrote:

> In D152351#4403904 <https://reviews.llvm.org/D152351#4403904>, @aaron.ballman wrote:
>
>> In D152351#4402785 <https://reviews.llvm.org/D152351#4402785>, @arsenm wrote:
>>
>>> Also should get mentioned in the builtin docs and release notes
>>
>> +1, also, should there be named constants for the mask values?
>
> I don't know where these constants could be placed.

The preprocessor predefines a bunch of macros, so I was thinking along those same lines. e.g., https://github.com/llvm/llvm-project/blob/main/clang/lib/Frontend/InitPreprocessor.cpp#L737


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152351/new/

https://reviews.llvm.org/D152351



More information about the llvm-commits mailing list