[PATCH] D152059: [AVR] Replace shift-to-loop IR pass with common shift code

Ben Shi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 9 00:56:02 PDT 2023


benshi001 added inline comments.


================
Comment at: llvm/lib/Target/AVR/AVRISelLowering.cpp:2219
+  // Shift the registers by one.
+  insertMultibyteShift(LoopBB->end(), LoopBB, dl, PhiRegPairs, Opc, 1);
+
----------------
Will the field `second` of `PhiRegPairs` be over written to `sub_lo` or `sub_hi` by `insertMultibyteShift` ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152059/new/

https://reviews.llvm.org/D152059



More information about the llvm-commits mailing list