[PATCH] D152423: [RISCV] Add function that check extension name with version

Piyou Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 8 21:54:41 PDT 2023


BeMg added inline comments.


================
Comment at: llvm/lib/Support/RISCVISAInfo.cpp:184
 // will be at least more than one character.
-static size_t findFirstNonVersionCharacter(StringRef Ext) {
+static size_t findLastNonVersionCharacter(StringRef Ext) {
   assert(!Ext.empty() &&
----------------
craig.topper wrote:
> Can you make a separate patch for renaming this?
OK


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152423/new/

https://reviews.llvm.org/D152423



More information about the llvm-commits mailing list