[PATCH] D152407: [AArch64] Merge LDRSWpre-LDRSWui pair into LDPSWpre.

Zhuojia Shen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 8 16:36:56 PDT 2023


chaosdefinition added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/ldrpre-ldr-merge.mir:608
+    early-clobber renamable $x1, renamable $x0 = LDRSWpre killed renamable $x1, 40 :: (load (s32))
+    renamable $x2 = LDRSWui renamable $x1, 1 :: (load (s32))
+    STRXui killed renamable $x0, renamable $x1, 0 :: (store (s64))
----------------
fhahn wrote:
> I think we should also have a test case with `LDURSWi` and variants where `LDRSWpre` is the second merge candidate. Preferably the tests will be submitted separately first.
Thanks for reviewing!  By submitting the tests first, I suppose merge cases should be no merge to avoid test failures and then updated to merge here, correct?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152407/new/

https://reviews.llvm.org/D152407



More information about the llvm-commits mailing list