[PATCH] D151419: [DebugInfo][RemoveDIs] Eliminate some debug-intrinsics-affect-codegen errors

Paul Robinson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 8 13:31:21 PDT 2023


probinson added a comment.

IIUC you're wanting to not add new tests that check for correct intrinsic-call placement, on the grounds that intrinsics are going away and those tests would ultimately be deleted.
If the tests are deleted, then how do we verify that the debug info (in its new form) is correct? The transforms will still transform the IR, and it would be very helpful when trying to track down future debug-info bugs if we still have a way to follow what the brave new world has in it. -dump-after-all is pretty handy in some of these cases, but if it stops showing debug info then future bug analysis may become much more difficult.

Hopefully the promised related patches will demonstrate this,


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151419/new/

https://reviews.llvm.org/D151419



More information about the llvm-commits mailing list