[PATCH] D151782: Improve WebAssembly vector bitmask, mask reduction, and extending

Thu Jun 8 12:17:16 PDT 2023

calebzulawski added a comment.

In D151782#4406514 <https://reviews.llvm.org/D151782#4406514>, @tlively wrote:

> Sorry for the breakage! Taking a look now. If a fix looks nontrivial, I'll revert.

I've already identified the issue, the assert is triggering due to vectors of length 1. In that case, the combine step should be skipped.

Also, I noticed only the modified tests made it into the commit, not the new tests I added. Would you like me to open a new review with the changes? Thanks!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151782/new/

https://reviews.llvm.org/D151782