[PATCH] D152456: SeparateConstOffsetFromGEP: Preserve SCEV

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 8 09:19:31 PDT 2023


arsenm created this revision.
arsenm added reviewers: AMDGPU, tra, jingyue, tstellar, nikic, Peakulorain, aeubanks, jroelofs, ajwock, sanjoy, reames, fhahn.
Herald added subscribers: luke, mattd, gchakrabarti, asavonic, StephenFan, frasercrmck, kerbowa, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, javed.absar, zzheng, jrtc27, niosHD, sabuasal, simoncook, johnrusso, rbar, asb, hiraditya, jvesely.
Herald added a project: All.
arsenm requested review of this revision.
Herald added subscribers: pcwang-thead, MaskRay, wdng, jholewinski.
Herald added a project: LLVM.

As far as I can tell nothing needs to be done for this and the
verifier flags seem happy. If I more broadly enable the verifiers,
there seem to be a lot of failures caused by other passes.

      

Fixes using SCEV for one pass and then immediately recomputing it. It
now survives for two passes before getting cleared by EarlyCSE, to be
immediately re-run after.


https://reviews.llvm.org/D152456

Files:
  llvm/lib/Transforms/Scalar/SeparateConstOffsetFromGEP.cpp
  llvm/test/CodeGen/AMDGPU/llc-pipeline.ll
  llvm/test/Transforms/SeparateConstOffsetFromGEP/AArch64/scalable-vector-geps.ll
  llvm/test/Transforms/SeparateConstOffsetFromGEP/AArch64/split-gep.ll
  llvm/test/Transforms/SeparateConstOffsetFromGEP/AMDGPU/split-gep-and-gvn-addrspace-addressing-modes.ll
  llvm/test/Transforms/SeparateConstOffsetFromGEP/AMDGPU/split-gep.ll
  llvm/test/Transforms/SeparateConstOffsetFromGEP/NVPTX/split-gep-and-gvn.ll
  llvm/test/Transforms/SeparateConstOffsetFromGEP/NVPTX/split-gep.ll
  llvm/test/Transforms/SeparateConstOffsetFromGEP/RISCV/split-gep.ll
  llvm/test/Transforms/SeparateConstOffsetFromGEP/crash-in-unreachable-code.ll
  llvm/test/Transforms/SeparateConstOffsetFromGEP/pointer-type-not-offset-type.ll
  llvm/test/Transforms/SeparateConstOffsetFromGEP/pr45371-find-either-reset.ll
  llvm/test/Transforms/SeparateConstOffsetFromGEP/pr62379-zeroext-negative.ll
  llvm/test/Transforms/SeparateConstOffsetFromGEP/split-gep-sub.ll
  llvm/test/Transforms/SeparateConstOffsetFromGEP/test-add-sub-separation.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D152456.529629.patch
Type: text/x-patch
Size: 11445 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230608/ccc47308/attachment.bin>


More information about the llvm-commits mailing list