[PATCH] D151932: Add dsymutil dwarf5 tests for darwin

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: llvm/test/tools/dsymutil/ARM/dummy-debug-map-amr64.map:1
 # This is a dummy debug map used for some tests where the contents of the
 # map are just an implementation detail. The tests wanting to use that file
----------------
Is there a type in the file name!?


================
Comment at: llvm/test/tools/dsymutil/ARM/dwarf5-dwarf4-combination-macho.test:1
+; This test checks to ensure that if a dawrf5 and dwarf4 object file is used to
+; generate a dsym, dsymutil correctly outputs the debug information, by keeping
----------------
typo: DWARF


================
Comment at: llvm/test/tools/dsymutil/ARM/dwarf5-dwarf4-combination-macho.test:2
+; This test checks to ensure that if a dawrf5 and dwarf4 object file is used to
+; generate a dsym, dsymutil correctly outputs the debug information, by keeping
+; the dwarf5 and dwarf4 debug info distinct, and that all the section headers 
----------------
We tend to spell this `DWARF v5` in most places.


================
Comment at: llvm/test/tools/dsymutil/ARM/dwarf5-dwarf4-combination-macho.test:30
+
+; clang -g -c -O1 b.cpp -Xclang -dwarf-version=4 -o 2.O
+
----------------
typo: 2.o


================
Comment at: llvm/test/tools/dsymutil/ARM/dwarf5-macho.test:1
+; This test checks to ensure that dwarf5 debug info can be correctly linked
+; into a dsym bundle by dsymutil, with the correct section names and dwarf5
----------------
checks to ensure that -> checks that


================
Comment at: llvm/test/tools/dsymutil/ARM/dwarf5-macho.test:2
+; This test checks to ensure that dwarf5 debug info can be correctly linked
+; into a dsym bundle by dsymutil, with the correct section names and dwarf5
+; headers for the different sections.
----------------
dSYM


================
Comment at: llvm/test/tools/dsymutil/ARM/dwarf5-macho.test:8
+; a.cpp
+; __attribute__((section("1,__text_foo"))) void foo() {}
+; 
----------------
why is this needed?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151932/new/

https://reviews.llvm.org/D151932